Refactor Bloom, JSON and RTS tests#4462
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
Test Results 183 files + 7 183 suites +7 11m 36s ⏱️ +34s Results for commit c8a608d. ± Comparison against base commit 3aa8b7c. This pull request removes 454 and adds 832 tests. Note that renamed tests count towards both.This pull request removes 12 skipped tests and adds 6 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
ac3360e to
c62c053
Compare
Reformat Remove duplicated JsonObjects
2543f13 to
8d35a7f
Compare
ggivo
left a comment
There was a problem hiding this comment.
Nice!
LGTM
Just one question before approving
I see a few tests related to time series are missing compared to the previous TimeSeriesTest.java. Is this intentional, and what it the motivation?

Note
Low Risk
Low risk because changes are confined to test code and Maven test include patterns, with no production logic changes; main risk is altered CI test selection/execution due to new/removed test classes and tags.
Overview
Refactors module integration testing by replacing legacy
RedisModuleCommandsTestBaseBloom/RedisJSON tests with newUnifiedJedisCommandsTestBase-based suites (bloom,json,timeseries) and updating shared JSON test helpers to the non-modulespackage.Adds new parameterized
RedisClientandClusterintegration tests that reuse these base suites (with cluster gating via@SinceRedisVersionand selective disabling for label-based TimeSeries cluster queries), and updatespom.xmltest includes so the new unified module tests are picked up by the build.Reviewed by Cursor Bugbot for commit 4a93fe3. Bugbot is set up for automated code reviews on this repo. Configure here.