[Dashboard] update total for dark mode color#60106
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where the 'total' legend color was not visible in dark mode. The change correctly uses a different color for dark mode. My review includes a suggestion to use a theme token (theme.palette.text.primary) instead of hardcoded colors, which is more idiomatic with Material-UI and improves maintainability. I also pointed out that the same fix is needed in the LegendTooltip component within the same file to ensure consistency.
coqian
approved these changes
Jan 13, 2026
ray-gardener
Bot
added
core
cristianjd
force-pushed
the
cristian/dark-mode-total
branch
from
26f6ee6 to
f64bad7
Compare
Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
cristianjd
force-pushed
the
cristian/dark-mode-total
branch
from
f64bad7 to
09eb033
Compare
dayshah
approved these changes
Jan 14, 2026
rushikeshadhav
pushed a commit
to rushikeshadhav/ray
that referenced
this pull request
Jan 14, 2026
Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the "total" color in the legend so it is visible in dark mode by using
text.primarywhich will correctly apply the dark or light text colorRelated issues
Follow up to dark mode PR: #58768
Additional information
Before:
After:
