Skip to content

add config files for async inf template#59926

Merged
abrarsheikh merged 1 commit into
masterfrom
add-anyscale-config-file-for-async-inf
Jan 7, 2026
Merged

add config files for async inf template#59926
abrarsheikh merged 1 commit into
masterfrom
add-anyscale-config-file-for-async-inf

Conversation

@harshit-anyscale

Copy link
Copy Markdown
Contributor
  • adding anyscale template configs for async inf template

Signed-off-by: harshit <harshit@anyscale.com>
@harshit-anyscale harshit-anyscale requested review from a team as code owners January 7, 2026 09:56
@harshit-anyscale harshit-anyscale self-assigned this Jan 7, 2026
@harshit-anyscale harshit-anyscale added the go add ONLY when ready to merge, run all tests label Jan 7, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds Anyscale template configurations for AWS and GCE for the asynchronous inference tutorial. The changes are straightforward. My review includes suggestions to explicitly define CPU resources for the head node in both configuration files. This improves clarity and ensures robust resource allocation, making the configurations more aligned with best practices and other similar files in the repository.

Comment on lines +1 to +3
head_node_type:
name: head
instance_type: m5.2xlarge

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For clarity and to ensure correct resource allocation for the head node, it's good practice to explicitly define its resources. While Ray can sometimes infer resources from the instance type, specifying them explicitly makes the configuration more robust and easier to understand. The m5.2xlarge instance has 8 vCPUs.

head_node_type:
  name: head
  instance_type: m5.2xlarge
  resources:
    cpu: 8

Comment on lines +1 to +3
head_node_type:
name: head
instance_type: n1-standard-8

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For clarity and to ensure correct resource allocation for the head node, it's good practice to explicitly define its resources. While Ray can sometimes infer resources from the instance type, specifying them explicitly makes the configuration more robust and easier to understand. The n1-standard-8 instance has 8 vCPUs.

head_node_type:
  name: head
  instance_type: n1-standard-8
  resources:
    cpu: 8

@ray-gardener ray-gardener Bot added serve Ray Serve Related Issue docs An issue or change related to documentation labels Jan 7, 2026
@abrarsheikh abrarsheikh merged commit 61818ea into master Jan 7, 2026
6 checks passed
@abrarsheikh abrarsheikh deleted the add-anyscale-config-file-for-async-inf branch January 7, 2026 17:01
AYou0207 pushed a commit to AYou0207/ray that referenced this pull request Jan 13, 2026
- adding anyscale template configs for async inf template

Signed-off-by: harshit <harshit@anyscale.com>
Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs An issue or change related to documentation go add ONLY when ready to merge, run all tests serve Ray Serve Related Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants