[Core][Doc] Add internal documentation for Port Service Discovery#59844
Merged
edoakes merged 3 commits intoJan 16, 2026
Conversation
Signed-off-by: yicheng <yicheng@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces valuable internal documentation for Ray's port service discovery mechanism. The document is well-structured, clear, and effectively explains the core concepts, including the 'bind-then-report' pattern and the different discovery layers. The inclusion of source code links is a great aid for developers. I have one minor suggestion to enhance the documentation's accuracy concerning the port file naming convention.
ray-gardener
Bot
added
docs
ZacAttack
reviewed
Jan 5, 2026
ZacAttack
reviewed
Jan 5, 2026
ZacAttack
reviewed
Jan 5, 2026
ZacAttack
reviewed
Jan 5, 2026
ZacAttack
reviewed
Jan 5, 2026
ZacAttack
reviewed
Jan 5, 2026
ZacAttack
requested changes
Jan 5, 2026
ZacAttack
left a comment
ZacAttack
left a comment
Contributor
There was a problem hiding this comment.
Looks pretty good, but some nits
Signed-off-by: yicheng <yicheng@anyscale.com>
ZacAttack
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add internal documentation for Port Service Discovery
Related issues
Additional information