[Serve] Bug fix: controller logs are too verbose#59501
Merged
Merged
Conversation
Signed-off-by: abrar <abrar@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the issue of verbose controller logs by moving the deployment logging statements and changing their level from INFO to DEBUG. The changes are well-placed after the early-exit condition, ensuring that logs are only generated when a deployment or update is actually occurring. This is a good improvement for log clarity and reduces unnecessary noise. The implementation is clean and correct. I have no further suggestions.
ray-gardener
Bot
added
serve
Contributor
|
Hi @abrarsheikh The previous modification did have this issue. This fix LGTM. |
harshit-anyscale
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old log line was getting executed as part of the control loop unconditionally.
cc @KeeProMise