[fix][dashboard]Fix the card content on the overview page is incomplete.#56947
Merged
Conversation
Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
ray-gardener
Bot
added
dashboard
edoakes
added
go
Collaborator
|
@alanwguo PTAL |
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
github-actions
Bot
added
the
stale
jjyao
removed
the
stale
alanwguo
reviewed
Oct 14, 2025
| overflow: "hidden", | ||
| overflowY: "scroll", | ||
| overflowY: "auto", | ||
| height: "100%", |
Contributor
There was a problem hiding this comment.
thanks! can you post a screenshot?
Why do we need the height: 100% value?
Contributor
Author
There was a problem hiding this comment.
Of course!
This is the effect when using height: 100%:
Below is the effect without using height: 100%, and the scroll bar cannot be displayed
alanwguo
approved these changes
Oct 15, 2025
alanwguo
left a comment
alanwguo
left a comment
Contributor
There was a problem hiding this comment.
thanks for the contribution!
jjyao
approved these changes
Oct 15, 2025
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
…te. (ray-project#56947) Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: xgui <xgui@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Oct 23, 2025
…te. (#56947) Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…te. (ray-project#56947) Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
…te. (ray-project#56947) Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: Future-Outlier <eric901201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR fix the issue of the card content on the overview page is incomplete. When the content of the Node Status card on the Overview page exceeds the fixed height of the card, there is no scroll bar as expected, and the extremely long content cannot be displayed. And when the content height of the Node Status card and Resource Status card is not too long, a scrolling area is also displayed, although it does not need to be scrolled. I recommend that the scroll bar be displayed when the height is insufficient, otherwise it will not be displayed.
I tested this PR against the latest version and resolved the incomplete card content on the page.
Related issue number
Closes #56923
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.