You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Thomasdezeeuw@djc is there a specific reason to upgrade to socket2v0.6, or is the goal of this pull request to simply keep up with the latest release?
If the latter is the case, would you be open to supporting both v0.5 and v0.6? Firefox is still on socket2v0.5. Supporting both would ease our upgrade path. I can create a pull request.
If the latter is the case, would you be open to supporting both v0.5 and v0.6? Firefox is still on socket2v0.5. Supporting both would ease our upgrade path. I can create a pull request.
Sounds okay to me. Can we keep the Cargo.lock at 0.6?
If the latter is the case, would you be open to supporting both v0.5 and v0.6? Firefox is still on socket2v0.5. Supporting both would ease our upgrade path. I can create a pull request.
Sounds okay to me. Can we keep the Cargo.lock at 0.6?
Yes. That would be my preference as well.
@mxinden my goal as maintainer of socket2 is update everyone to v0.6, but socket2 v0.5 is still supported.
Great.
Thank you both for the help!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.