Skip to content

Update to socket2 v0.6#2291

Merged
djc merged 1 commit into
quinn-rs:mainfrom
Thomasdezeeuw:update-socket2
Jul 5, 2025
Merged

Update to socket2 v0.6#2291
djc merged 1 commit into
quinn-rs:mainfrom
Thomasdezeeuw:update-socket2

Conversation

@Thomasdezeeuw

Copy link
Copy Markdown
Contributor

No description provided.

@djc djc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djc djc added this pull request to the merge queue Jul 5, 2025
Merged via the queue into quinn-rs:main with commit 68041e1 Jul 5, 2025
19 of 20 checks passed
@Thomasdezeeuw

Copy link
Copy Markdown
Contributor Author

You're the fastest to merge out my 20 prs. Nice!

@mxinden

mxinden commented Jul 7, 2025

Copy link
Copy Markdown
Collaborator

@Thomasdezeeuw @djc is there a specific reason to upgrade to socket2 v0.6, or is the goal of this pull request to simply keep up with the latest release?

If the latter is the case, would you be open to supporting both v0.5 and v0.6? Firefox is still on socket2 v0.5. Supporting both would ease our upgrade path. I can create a pull request.

@djc

djc commented Jul 7, 2025

Copy link
Copy Markdown
Member

If the latter is the case, would you be open to supporting both v0.5 and v0.6? Firefox is still on socket2 v0.5. Supporting both would ease our upgrade path. I can create a pull request.

Sounds okay to me. Can we keep the Cargo.lock at 0.6?

@Thomasdezeeuw

Copy link
Copy Markdown
Contributor Author

@mxinden my goal as maintainer of socket2 is update everyone to v0.6, but socket2 v0.5 is still supported.

@mxinden

mxinden commented Jul 7, 2025

Copy link
Copy Markdown
Collaborator

If the latter is the case, would you be open to supporting both v0.5 and v0.6? Firefox is still on socket2 v0.5. Supporting both would ease our upgrade path. I can create a pull request.

Sounds okay to me. Can we keep the Cargo.lock at 0.6?

Yes. That would be my preference as well.

@mxinden my goal as maintainer of socket2 is update everyone to v0.6, but socket2 v0.5 is still supported.

Great.

Thank you both for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants