proto: Refactor TokenDecodeError#2085
Merged
Merged
Conversation
Ralith
approved these changes
Dec 14, 2024
eb5423b to
f53f8f2
Compare
f53f8f2 to
4a80c3f
Compare
Ralith
approved these changes
Dec 15, 2024
djc
approved these changes
Dec 16, 2024
Member
|
Nice! |
This was referenced Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consists solely of renames and docs changes.
Renames enum
TokenDecodeError->ValidationErrorTokenDecodeErroris used when that there was an error decoding a token, but is also when there was no error decoding the token but the token contained an address not applicable to the current situation. Thus, this rename more accurately reflects the purpose of the error.Renames variant
UnknownToken->UnusableIgnoreUnknownTokenis used when a token cannot be decoded or deserialized, and triggers the token to be ignored. Thus, it's name is currently an accurate description of how it's used, however, I found it very confusing why we use it like that, and had to get Ralith to explain it to me. Moreover, in the future, this error would be applicable to situations where a token can be unambiguously decrypted/decoded as a token from a NEW_TOKEN frame, but is simply not valid. In that situation, the variant name would cease to be an accurate description of how it's used. Thus, we rename it to a more accurately describe the sorts of situations it would apply to, and leave a detailed comment on the variant explaining the rationale. Relatedly, we remove a comment fromendpoint.rsfor being now-redundant.At one point, in Utilize NEW_TOKEN frames #1912, I tried the name
InvalidMaybeNewToken, but Ralith seemed hesitant. While that name was more descriptive, it's also pretty cumbersome.Renames variant
WrongAddress->InvalidRetryWrongAddressis used when a token can be successfully decoded and deserialized but has the wrong client address, and triggers the connection to be closed. Thus, it's name is currently an accurate description of how it's used. However, if in the future we start processing tokens from NEW_TOKEN frames, this error would not be applicable to situations where a token can be unambiguously decrypted/decoded as a token from a NEW_TOKEN frame but has the wrong client address, as the appropriate way to handle that situation would be to ignore the token rather than close the connection, so we would have to use a different error. In that situation, the variant name would cease to be an accurate description of how it's used. Thus, we rename it to a more accurately describe the sorts of situations it would apply to.An additional conceivable benefit of this name is that it would make it easier to potentially add future cases where a token can be unambiguously identified as a token from a Retry packet, but still cannot be fully decrypted or deserialized, or where it is otherwise for some reason unusable.