Skip to content

Revert "#6586 - Avoid DivisionByZero error when TensorNetwork simplifies to a scalar"#6958

Merged
pavoljuhas merged 1 commit into
quantumlib:mainfrom
pavoljuhas:revert-pr-6586
Jan 17, 2025
Merged

Revert "#6586 - Avoid DivisionByZero error when TensorNetwork simplifies to a scalar"#6958
pavoljuhas merged 1 commit into
quantumlib:mainfrom
pavoljuhas:revert-pr-6586

Conversation

@pavoljuhas

Copy link
Copy Markdown
Collaborator

The workaround is not needed after upstream fixes in quimb and
our upgraded requirements for a later quimb version.

This reverts commit bfba965.

…rk simplifies to a scalar"

The workaround is not needed after upstream fixes in quimb and
our upgraded requirements for a later quimb version.

This reverts commit bfba965.
@codecov

codecov Bot commented Jan 17, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (5cc14ba) to head (1893e18).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6958      +/-   ##
==========================================
- Coverage   97.87%   97.87%   -0.01%     
==========================================
  Files        1084     1084              
  Lines       94579    94577       -2     
==========================================
- Hits        92568    92564       -4     
- Misses       2011     2013       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas pavoljuhas marked this pull request as ready for review January 17, 2025 17:26
@pavoljuhas pavoljuhas requested review from a team and vtomole as code owners January 17, 2025 17:26
@pavoljuhas pavoljuhas requested a review from dabacon January 17, 2025 17:26
@pavoljuhas pavoljuhas added this pull request to the merge queue Jan 17, 2025
Merged via the queue into quantumlib:main with commit 426178b Jan 17, 2025
@pavoljuhas pavoljuhas deleted the revert-pr-6586 branch January 17, 2025 17:40
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
…rk simplifies to a scalar" (quantumlib#6958)

The workaround is not needed after upstream fixes in quimb and
our upgraded requirements for a later quimb version.

This reverts commit bfba965.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants