Skip to content

Check that control and target qubits disjoint in ControlledOperations#5286

Merged
95-martin-orion merged 4 commits into
quantumlib:masterfrom
daxfohl:controlled-circuitop
Apr 25, 2022
Merged

Check that control and target qubits disjoint in ControlledOperations#5286
95-martin-orion merged 4 commits into
quantumlib:masterfrom
daxfohl:controlled-circuitop

Conversation

@daxfohl

@daxfohl daxfohl commented Apr 23, 2022

Copy link
Copy Markdown
Collaborator

Adds check that control and target qubits are disjoint and that control qubits are unique, plus tests.

xref #4007

@daxfohl daxfohl requested review from a team, cduck and vtomole as code owners April 23, 2022 19:35
@daxfohl daxfohl requested a review from mpharrigan April 23, 2022 19:35
@CirqBot CirqBot added the size: S 10< lines changed <50 label Apr 23, 2022
@95-martin-orion 95-martin-orion merged commit 859a16d into quantumlib:master Apr 25, 2022
@daxfohl daxfohl deleted the controlled-circuitop branch April 26, 2022 14:17
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
…quantumlib#5286)

* Check that control and target qubits don't overlap in ControlledOperations

* Add unique control qubits constraint

* reformat imports

* reformat imports
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
…quantumlib#5286)

* Check that control and target qubits don't overlap in ControlledOperations

* Add unique control qubits constraint

* reformat imports

* reformat imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants