Fail gracefully when line number is out-of-bounds and negative - #10868
Closed
jakevdp wants to merge 2 commits into
Closed
Fail gracefully when line number is out-of-bounds and negative#10868jakevdp wants to merge 2 commits into
jakevdp wants to merge 2 commits into
Conversation
Member
|
Seems similar/duplicate to #10840. |
Contributor
Author
|
Yep, looks like a duplicate. Consider this a +1 for getting that PR in ASAP! |
Contributor
Author
|
It looks like that PR is stalled on lack of tests – would it help to pull in the tests I wrote here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue I ran into that is similar to #752.
I don't have a self-contained repro for this failure, but an example of the failure is in the nightly CI for the JAX project: https://github.com/google/jax/actions/runs/4607513902/jobs/8142126075. The last few lines of the traceback looks like this:
Reading through the source, I see that positive out-of-bound indices are already handled gracefully:
pytest/src/_pytest/_code/code.py
Lines 746 to 748 in 31d0b51
Given this, I suspect the only possible way to hit the error I'm seeing is if the list index is out of range and negative.