Skip to content

Require configure before lazy remote variables#2002

Open
alexmojaki wants to merge 1 commit into
mainfrom
codex/lazy-remote-vars-require-config
Open

Require configure before lazy remote variables#2002
alexmojaki wants to merge 1 commit into
mainfrom
codex/lazy-remote-vars-require-config

Conversation

@alexmojaki
Copy link
Copy Markdown
Collaborator

Summary

  • Require logfire.configure() before LOGFIRE_API_KEY can lazily enable the remote variable provider
  • Keep lazy remote provider initialization after configuration when variables= is omitted
  • Update managed-variable docs to describe the configure-first behavior

Tests

  • uv run pytest tests/test_variables.py::TestLazyVariableProviderInit -q
  • uv run ruff check logfire/_internal/config.py tests/test_variables.py
  • Pre-commit via gcap: Ruff, Ruff Format, pyright

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant