Replace contour-authserver in e2e with gRPC server running in test suite#7597
Draft
tsaarni wants to merge 1 commit into
Draft
Replace contour-authserver in e2e with gRPC server running in test suite#7597tsaarni wants to merge 1 commit into
tsaarni wants to merge 1 commit into
Conversation
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
4e588a0 to
7425508
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7597 +/- ##
=======================================
Coverage 82.35% 82.35%
=======================================
Files 130 130
Lines 15873 15873
=======================================
Hits 13073 13073
Misses 2513 2513
Partials 287 287 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes dropping
contour-authserveras a dependency for the e2e test suite and replacing it with a test server stub that runs directly within the test case.This approach makes the external authorization tests self-contained, allowing the authorization server to be easily programmed to return specific responses or assert request parameters right inside the test case.
This is similar to the HTTP-based authorization server I mentioned here: #7418 (comment)
Additionally,
contour-authserverhas not been maintained for a long time, with its last release in 2023. It might be better to archive that project altogether.