Add support for resource tagging in Azure deployment templates#1046
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds end-user support for tagging Azure resources when deploying Acmebot via the Guided UI, flowing tag selections from uiFormDefinition.json into the azuredeploy_ui ARM/Bicep templates and applying them to key resources.
Changes:
- Added a
tagsByResourceparameter (sourced fromMicrosoft.Common.TagsByResource) and propagated it through the Guided UI output parameters. - Applied per-resource-type tags to Storage Account, Log Analytics Workspace, Application Insights, App Service Plan, Function App, and Key Vault.
- Merged Application Insights user tags with required hidden-link tags.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| deploy/uiFormDefinition.json | Adds a new “Tags” step and passes tagsByResource into template parameters. |
| deploy/azuredeploy_ui.bicep | Introduces tagsByResource, derives per-resource tag objects, and applies them to resources (including AI hidden-link merge). |
| deploy/azuredeploy_ui.json | Generated ARM template updates mirroring the Bicep changes, including new parameter/variables and tags fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for applying custom tags to Azure resources through the deployment UI. It introduces a new
tagsByResourceparameter, updates the Bicep and ARM templates to propagate tags to all key resources, and enhances the deployment UI to allow users to specify tags per resource type.Tagging support for Azure resources:
tagsByResourceparameter inazuredeploy_ui.bicepandazuredeploy_ui.jsonto allow users to specify tags for each resource type. This parameter is now passed throughout the deployment pipeline. [1] [2]azuredeploy_ui.bicepandazuredeploy_ui.jsonto apply the appropriate tags fromtagsByResourceto Storage Account, Log Analytics Workspace, Application Insights, App Service Plan, Function App, and Key Vault resources. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Deployment UI enhancements:
uiFormDefinition.json) with aMicrosoft.Common.TagsByResourceelement, allowing users to input tags for each supported resource type.These changes provide greater flexibility and consistency in resource tagging, improving resource management and cost tracking across deployments.
Close #839