Skip to content

Fixed the "-- Comment" SQL case (Fixes #1066) - #1067

Open
dsevilla wants to merge 8 commits into
ploomber:masterfrom
dsevilla:master
Open

Fixed the "-- Comment" SQL case (Fixes #1066)#1067
dsevilla wants to merge 8 commits into
ploomber:masterfrom
dsevilla:master

Conversation

@dsevilla

@dsevilla dsevilla commented Aug 14, 2025

Copy link
Copy Markdown

Two fixes where added:

Describe your changes

Issue number

Closes #1066

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--1067.org.readthedocs.build/en/1067/

Two fixes where added:

- The "-- Comment" case
- The "begin" transaction was checked only at the beginning of the %%sql block, not for each statement. I fixed it, but I'm not sure how it does work at the already executed queries. This test should be performed earlier similar to what I changed to fix ploomber#1066.
@dsevilla
dsevilla requested a review from edublancas as a code owner August 14, 2025 09:24
@dsevilla

Copy link
Copy Markdown
Author

Any work on this? I've seen that the problem of the merge is caused by other parts of the code failing with recent versions of SQL Alchemy. Should I contribute to fix these too?

@edublancas

Copy link
Copy Markdown

hi @dsevilla, yeah if you can help fix the CI, that'd be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

run.py logic with comments and/or zero or several statements is flawed

2 participants