⚡ Bolt: Remove intermediate vector allocations in TUI render loop#110
Conversation
Co-authored-by: julesklord <801266+julesklord@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Refactored the TUI rendering loop in
src/ui.rsto constructListItems directly from the application state iterators (app.themes,app.fonts,app.segments) rather than allocating intermediate vectors by callingapp.filtered_*methods. Removed the now-unusedfiltered_fontsandfiltered_segmentsmethods insrc/app/services.rsand updated tests.🎯 Why: Calling
.collect()into intermediate collections merely to iterate over them and map them to UI items creates unnecessaryVecallocations, leading to increased memory pressure and garbage collection overhead during Ratatui's high-frequency render loops.📊 Impact: Eliminates
O(N)heap allocations and deep cloning of structs during each frame render for the fonts and segments views.🔬 Measurement: Verify changes compile correctly via
cargo checkand execute without failure viacargo testandnpx playwright test. Observe reduced CPU and memory footprint during continuous TUI list filtering.PR created automatically by Jules for task 17225690199213653854 started by @julesklord