Skip to content

⚡ Bolt: Remove intermediate vector allocations in TUI render loop#110

Merged
julesklord merged 1 commit into
mainfrom
perf-tui-alloc-17225690199213653854
May 6, 2026
Merged

⚡ Bolt: Remove intermediate vector allocations in TUI render loop#110
julesklord merged 1 commit into
mainfrom
perf-tui-alloc-17225690199213653854

Conversation

@julesklord

Copy link
Copy Markdown
Member

💡 What: Refactored the TUI rendering loop in src/ui.rs to construct ListItems directly from the application state iterators (app.themes, app.fonts, app.segments) rather than allocating intermediate vectors by calling app.filtered_* methods. Removed the now-unused filtered_fonts and filtered_segments methods in src/app/services.rs and updated tests.
🎯 Why: Calling .collect() into intermediate collections merely to iterate over them and map them to UI items creates unnecessary Vec allocations, leading to increased memory pressure and garbage collection overhead during Ratatui's high-frequency render loops.
📊 Impact: Eliminates O(N) heap allocations and deep cloning of structs during each frame render for the fonts and segments views.
🔬 Measurement: Verify changes compile correctly via cargo check and execute without failure via cargo test and npx playwright test. Observe reduced CPU and memory footprint during continuous TUI list filtering.


PR created automatically by Jules for task 17225690199213653854 started by @julesklord

Co-authored-by: julesklord <801266+julesklord@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@julesklord julesklord merged commit a3f368e into main May 6, 2026
10 checks passed
@julesklord julesklord deleted the perf-tui-alloc-17225690199213653854 branch June 13, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant