Fix player being unable to collide with Stations if only ship in Frame - #5720
Merged
Merged
Conversation
- Partition sort had a degenerate case where 1 element in the array would always be assigned to the disabled bucket, regardless of if it passed the partitioning test. - The fix also makes the sort logic generally simpler as a side benefit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CollisionSpace partition sort algorithm had a degenerate case where the contents of a single-element array would always be assigned to the disabled bucket, regardless of if it was enabled or not. This resulted in the player being unable to collide with any static Geom if it was the only active ship in the physics frame.
I've fixed that, and in the process made the sort algorithm a bit simpler.
Fixes #5705. Note that the saves linked in that issue are not compatible with the current master branch.