Fix issue on quitting Lua console - #5597
Merged
Merged
Conversation
Key release event was eaten by ImGui input focus - delay opening of console until key release instead.
sturnclaw
self-requested a review
July 23, 2023 00:21
sturnclaw
approved these changes
Jul 23, 2023
Member
|
Thanks @zonkmachine! Appreciate you digging into the issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5287, fixes #5598.
Escaping out of the Lua console on keypress created issues since the key was then released in another window and escape key release action performed. Fixed by exiting Lua console on escape key release instead of press.