Skip to content

Make username parsing more robust - #568

Merged
sirzooro merged 1 commit into
pion:mainfrom
sirzooro:fix_userid_parsing
May 28, 2026
Merged

Make username parsing more robust#568
sirzooro merged 1 commit into
pion:mainfrom
sirzooro:fix_userid_parsing

Conversation

@sirzooro

@sirzooro sirzooro commented May 28, 2026

Copy link
Copy Markdown
Contributor

Username without colon causes panic

@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.98%. Comparing base (f8c9cf8) to head (4463b19).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
+ Coverage   81.73%   81.98%   +0.25%     
==========================================
  Files          46       46              
  Lines        3197     3197              
==========================================
+ Hits         2613     2621       +8     
+ Misses        382      376       -6     
+ Partials      202      200       -2     
Flag Coverage Δ
go 81.98% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sirzooro
sirzooro force-pushed the fix_userid_parsing branch from 3c88fad to 4463b19 Compare May 28, 2026 07:37

@JoTurk JoTurk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@sirzooro
sirzooro merged commit e6b1c7d into pion:main May 28, 2026
18 checks passed
@sirzooro
sirzooro deleted the fix_userid_parsing branch May 28, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants