check attribute lengths before reading them - #2986
Open
010011110 wants to merge 1 commit into
Open
Conversation
Netlink attributes are variable-length, so a fixed-size read can run past the payload into the next attribute. Signed-off-by: 010011110 <duckenheim@posteo.de>
Member
Thereafter, this can be approved and merged without changes. |
Author
|
How to do it? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
Netlink attributes are variable-length, so a fixed-size read can run past the payload into the next attribute.
How does this PR accomplish the above?:
Fix the checks.
Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase)This is my first contribution to open source. I have used Claude Code AI and OpenCodex AI to write and review this code and tried to test it as good as I can. But I was not able to cause a crash before and not with this fix. This fix is created after reading #2984 and seeing there are similar places in the same file.