Skip to content

check attribute lengths before reading them - #2986

Open
010011110 wants to merge 1 commit into
pi-hole:developmentfrom
010011110:development-1
Open

check attribute lengths before reading them#2986
010011110 wants to merge 1 commit into
pi-hole:developmentfrom
010011110:development-1

Conversation

@010011110

Copy link
Copy Markdown

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

Netlink attributes are variable-length, so a fixed-size read can run past the payload into the next attribute.

How does this PR accomplish the above?:

Fix the checks.

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

This is my first contribution to open source. I have used Claude Code AI and OpenCodex AI to write and review this code and tried to test it as good as I can. But I was not able to cause a crash before and not with this fix. This fix is created after reading #2984 and seeing there are similar places in the same file.

Netlink attributes are variable-length, so a fixed-size read can run past
the payload into the next attribute.

Signed-off-by: 010011110 <duckenheim@posteo.de>
@010011110
010011110 requested a review from a team as a code owner July 30, 2026 17:27
@DL6ER

DL6ER commented Jul 30, 2026

Copy link
Copy Markdown
Member

Commits must have verified signatures.

Thereafter, this can be approved and merged without changes.

@010011110

Copy link
Copy Markdown
Author

How to do it?

@DL6ER

DL6ER commented Jul 30, 2026

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants