This repository was archived by the owner on Jan 8, 2024. It is now read-only.
Init Cake5 upgrade - #14
Merged
Merged
Conversation
dbu
reviewed
Jan 5, 2023
dbu
left a comment
dbu
left a comment
Contributor
There was a problem hiding this comment.
thanks, looks like no changes to the code are needed, right?
could we allow installation with both cake 4 and 5 in that case?
dbu
reviewed
Jan 5, 2023
Contributor
|
did you rename the .php_cs file to .php-cs-fixer.php? if so, the new file is missing in the pull request, which makes the ci fail. i will remove scrutinizer from the repository configuration. |
Collaborator
Author
|
It now uses a native cs approach, maybe you could remove that failing CI call as it is not needed |
Contributor
right. i removed the hooks for travis and styleci. |
composer.json - use stable CakePHP 5.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep new semantic major 0.4 release with CakePHP 5
WIP until Cake5 stable is released in a few months