fix: support scalar request and response bodies in InteractionContents#404
Open
SAY-5 wants to merge 1 commit into
Open
fix: support scalar request and response bodies in InteractionContents#404SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Member
|
Thanks Sai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InteractionContentsassumed every body was a hash, so a plain-string or integer body (or an array of scalars nested in a hash, e.g.{some_array: [42]}) raisedNoMethodError: undefined method 'each_pair'instead of serializing.serializenow returns non-collection values unchanged and a scalar body is exposed through#valueforwith_request/will_respond_withto pass to the FFI core.Added specs covering a plain string body, an integer body, and an array of scalars nested in a hash.
Fixes #402