Skip to content

refactor(linter): remove Message.fixed - #25040

Open
Sysix wants to merge 1 commit into
07-28-refactor_linter_remove_messagerule_from
07-28-refactor_linter_remove_message.fixed_
Open

refactor(linter): remove Message.fixed#25040
Sysix wants to merge 1 commit into
07-28-refactor_linter_remove_messagerule_from
07-28-refactor_linter_remove_message.fixed_

Conversation

@Sysix

@Sysix Sysix commented Jul 28, 2026

Copy link
Copy Markdown
Member

Pull request overview

This PR refactors the linter’s fixer diagnostics plumbing by removing the unused fixed state from fixer::Message, relying instead on the existing behavior where Fixer::fix() returns only the messages that were not applied.

Changes:

* Remove `fixed: bool` from `Message` and simplify `Message::new` accordingly.

* Simplify the fix-application loop by no longer mutating `Message` instances solely to toggle `fixed`.

Sysix commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the A-linter Area - Linter label Jul 28, 2026
@Sysix
Sysix force-pushed the 07-28-refactor_linter_remove_message.fixed_ branch from 2574269 to 960cabb Compare July 28, 2026 20:59
@Sysix
Sysix requested a review from Copilot July 28, 2026 20:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the linter’s fixer diagnostics plumbing by removing the unused fixed state from fixer::Message, relying instead on the existing behavior where Fixer::fix() returns only the messages that were not applied.

Changes:

  • Remove fixed: bool from Message and simplify Message::new accordingly.
  • Simplify the fix-application loop by no longer mutating Message instances solely to toggle fixed.

@Sysix
Sysix marked this pull request as ready for review July 28, 2026 21:02
@Sysix
Sysix requested a review from camc314 as a code owner July 28, 2026 21:02
@codspeed-hq

codspeed-hq Bot commented Jul 28, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 71 skipped benchmarks1


Comparing 07-28-refactor_linter_remove_message.fixed_ (960cabb) with 07-28-refactor_linter_remove_messagerule_ (8c16760)

Open in CodSpeed

Footnotes

  1. 71 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants