fix(ScanSummary): Turn licenses into a lazy initialized property#7316
Merged
Conversation
When the SPDX expressions are mapped into a `MutableSet`, then `equals` gets called on each added SPDX expression instance. Equals in turn calls `validChoicesForDnf()` which is quite slow. Turn the property into a lazy one, to remove the performance penalty from code paths which do not access that `licenses` property. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
sschuberth
approved these changes
Jul 20, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7316 +/- ##
=========================================
Coverage 61.20% 61.20%
Complexity 1969 1969
=========================================
Files 335 335
Lines 16489 16489
Branches 2350 2350
=========================================
Hits 10092 10092
Misses 5420 5420
Partials 977 977
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
|
The failing test was unrelated, merge regardlessly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the SPDX expressions are mapped into a
MutableSet, thenequalsgets called on each added SPDX expression instance. Equals in turn callsvalidChoicesForDnf()which is quite slow.Turn the property into a lazy one, to remove the performance penalty from code paths which do not access that
licensesproperty.