Improved pull request "Files Changed" experience feedback #163932
Replies: 3124 comments 1277 replies
-
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
The tab for |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
|
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
-
|
I am a screen reader (NVDA) and keyboard user. When arrowing down a file content to read line by line (in focus mode), the lines which contain comments are no longer reported to the screen reader. It used to be in earlier versions of this new PR expierience. Please restore it! Also, when a comment is opened, I need to jump back to the corresponding part of the code:
Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
BUG - I can't place a file comment on a deleted file (switched to the old experience to do so) |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
This comment was marked as low quality.
This comment was marked as low quality.
-
|
There's no way to process a review without being on the see files page. No way to jump to modified code or last seen section from a specific thread. |
Beta Was this translation helpful? Give feedback.
-
|
Commenting on a file change in a PR should not automatically mark you as having 'reviewed' the entire PR - I'm still reviewing it! Let ME decide when I'm actually done reviewing the PR. |
Beta Was this translation helpful? Give feedback.
-
|
When someone sends me a permalink and I had marked all files as viewed, github should disclose the file. I can't tell which file it is because permalink is to blobID or something. |
Beta Was this translation helpful? Give feedback.
-
|
Performance is way worse on chunky PRs (80-100 files changed and upwards). All interactions: scrolling down to load more files, checking files as viewed, leaving a comment on a line lag like crazy, everything takes a minimum of 2~10 seconds to load/update. |
Beta Was this translation helpful? Give feedback.
-
|
Since the new pull request "Files changed" / review experience became my default, my own comments collapse automatically right after I post them - they minimize to my avatar and I have to click to expand them to read what I just wrote. This is a real regression in my review workflow. What I've already ruled out:
The gap: there is no granular setting to keep the new experience but turn OFF automatic comment collapsing. It's all-or-nothing (new vs classic). And since classic is positioned as temporary, once it's retired there will be no way to avoid this behavior at all. Request: please add an account-level setting to disable automatic collapsing of comments in the new Files changed / PR experience, and please keep that option available before classic is removed. Auto-collapsing a user's own just-posted comment is a meaningful workflow regression. |
Beta Was this translation helpful? Give feedback.
-
|
Feature request for the new commit-by-commit view: add a positional counter — "Commit 3 of 5" — in the single-commit header, near to the Prev/Next controls. The updated "Files changed" experience now keeps you on-page when filtering to a single commit (great improvement), but there's still no indication of where you are in the commit sequence — only the SHA and Prev/Next. On multi-commit PRs you lose track of progress after a few clicks. Filed with full detail as #199931. |
Beta Was this translation helpful? Give feedback.
-
|
ADO PR Review has a feature worth learning: It allows you to select a folder on the left and only show changes to the files within that folder. I don't understand why GitHub displays changes to all files by default. We can't review all files at once; reviews are done piecemeal. Furthermore, GitHub can't hide already reviewed files, and the feature to collapse reviewed files often fails. I believe that displaying files based on a tree-like directory on the left could also solve the performance issues of large PRs. |
Beta Was this translation helpful? Give feedback.
-
|
There is no way to view replies to outdated comments in the new view, and navigating to even non-outdated comments often fails. There are three different links which I think should take you there: If I don't use the preview, I can navigate to the comments just fine, but it can be really slow. If I hit "." to open it in the in browser vs-code, I can nearly instantly navigate to any comments, so clearly it's possible to load them quickly. This is all in Edge on a basically standard configured Windows system. Here is an edited down video showing me try and fail at the three above noted ways to try and see the replies to a specific comment: Github.comments.mp4 |
Beta Was this translation helpful? Give feedback.
-
AnowarHOSSAIN Kanti Bangladesh Jhalak Mila post office number Bazar 30our boys free Hamare account Amber Doha Bank account number browserwww01015340297001 |
Beta Was this translation helpful? Give feedback.
























Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
✨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ Updates
See what's been fixed and improved since the launch of the public preview:
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions