Remove ProgressBar - #4044
Merged
AlexanderDokuchaev merged 1 commit intoApr 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the legacy ProgressBar implementation and its unit tests now that progress reporting is handled via track_progress.
Changes:
- Deleted
ProgressBarimplementation fromnncf.common.logging. - Removed the corresponding test suite for
ProgressBar.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/nncf/common/logging/progress_bar.py |
Removes the legacy logging-based progress bar implementation. |
tests/common/test_progress_bar.py |
Removes tests that exclusively covered the deleted ProgressBar. |
Comments suppressed due to low confidence (1)
src/nncf/common/logging/progress_bar.py:1
- Removing this module is a breaking change for any external users importing
nncf.common.logging.progress_bar.ProgressBar. Elsewhere in the repo, deprecated imports/APIs are typically kept as compatibility shims that emit a deprecation warning and re-export the new API (e.g.,src/nncf/common/utils/logger/__init__.py, deprecated functions insrc/nncf/torch/__init__.py). Consider keepingprogress_bar.pyas a thin deprecated wrapper that forwards totrack()/WeightedProgress(or add a ReleaseNotes entry if the removal is intentionally user-facing).
daniil-lyakhov
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Removed unused
ProgressBarclassReason for changes
Unused
Functionality had already been migrated to track instead