Skip to content

fix(sdk-trace): sample ratio 1 upper-bound trace IDs#6890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pichlermarc merged 2 commits into from
Jul 8, 2026
Merged

fix(sdk-trace): sample ratio 1 upper-bound trace IDs #6890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
499fcc5
fix(sdk-trace): sample full ratio upper bound
LarryHu0217 Jul 7, 2026
8cc5862
Add changelog entry for sampler fix
LarryHu0217 Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ For notes on migrating to 2.x / 0.200.x see [the upgrade guide](doc/upgrade-to-2

### :bug: Bug Fixes

* fix(sdk-trace): include trace IDs at the ratio 1 upper bound in `TraceIdRatioBasedSampler` [#6890](https://github.com/open-telemetry/opentelemetry-js/pull/6890) @LarryHu0217

### :books: Documentation

### :house: Internal
Expand Down
3 changes: 2 additions & 1 deletion packages/sdk-trace/src/sampler/TraceIdRatioBasedSampler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ export class TraceIdRatioBasedSampler implements Sampler {

constructor(ratio = 0) {
this._ratio = this._normalize(ratio);
this._upperBound = Math.floor(this._ratio * 0xffffffff);
this._upperBound =
this._ratio === 1 ? 0x100000000 : Math.floor(this._ratio * 0xffffffff);
}

shouldSample(context: unknown, traceId: string): SamplingResult {
Expand Down
10 changes: 10 additions & 0 deletions packages/sdk-trace/test/common/sampler/TraceIdRatioBasedSampler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,16 @@ describe('TraceIdRatioBasedSampler', () => {
decision: api.SamplingDecision.RECORD_AND_SAMPLED,
}
);

assert.deepStrictEqual(
sampler.shouldSample(
spanContext(traceId('ffffffff')),
traceId('ffffffff')
),
{
decision: api.SamplingDecision.RECORD_AND_SAMPLED,
}
);
});

it('should return a always sampler for >1', () => {
Expand Down
Loading