Permit keyword list start_opts in Tracer macros. - #228
Merged
ferd merged 2 commits intoMar 24, 2021
Conversation
Codecov Report
@@ Coverage Diff @@
## main #228 +/- ##
=======================================
Coverage 34.73% 34.73%
=======================================
Files 37 37
Lines 3052 3052
=======================================
Hits 1060 1060
Misses 1992 1992
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
garthk
force-pushed
the
feat/permit-keyword-list-start-opts
branch
from
March 22, 2021 22:50
6596930 to
ae9062c
Compare
ferd
approved these changes
Mar 22, 2021
Ergonomic for Elixir developers. Also: * Repair test name to reflect test code * Provide tested examples of `with_span/3` with `start_opts` expressed as both a map and keyword list
garthk
force-pushed
the
feat/permit-keyword-list-start-opts
branch
from
March 23, 2021 22:40
ae9062c to
f9ab9b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ergonomic for Elixir developers.
Also:
Repair test name to reflect test code
Provide tested examples of
with_span/3withstart_optsexpressed as both a map and keyword list