Add ability to have custom logger#522
Merged
Merged
Conversation
gustavohenke
requested changes
Dec 27, 2024
gustavohenke
left a comment
gustavohenke
left a comment
Member
There was a problem hiding this comment.
mind fixing the formatting errors?
Contributor
Author
|
@gustavohenke No problem! Just wanted to make sure you'd like to take the change first. PR updated. Thanks for the awesome lib 🚀 |
gustavohenke
approved these changes
Dec 31, 2024
Member
|
Published as v9.1.2. Happy new year! |
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The types allow for a custom logger to be passed in but it's never used.