Fix missing model support in preconditions#313
Merged
Conversation
Lucccyo
changed the title
n-osborne
approved these changes
May 26, 2025
Collaborator
There was a problem hiding this comment.
Thanks for this PR straight to the point :-)
I just have to small remarks.
- In
Ir_of_gospel.with_presis the type annotation for theirargument really necessary (if note I think you can also cleanup the one forvalue. - You don't need to add the PR's id on the same line as its description in
CHANGES.mdas it is present the line just after
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes the support for models in preconditions, a feature that was missing in PR #305.