Fix display of the runnable scenario for protected values#251
Merged
Conversation
Collaborator
Author
|
We now have this behaviour in case of a test failure (here adding |
21821ba to
ed755f5
Compare
Collaborator
Author
|
Rebased. Ready for review. |
nikolaushuber
approved these changes
Oct 1, 2024
Contributor
|
Not directly related, but since I stumbled upon it again during the review of this PR, there seems to be an issue with showing inbuilt types as return types: #260 Otherwise this PR LGTM :) |
Collaborator
Author
|
Thanks! Merging. |
n-osborne
added a commit
to n-osborne/opam-repository
that referenced
this pull request
Oct 8, 2024
This release brings a number of new features and improvements: - New features: + [ocaml#247](ocaml-gospel/ortac#247): Generated tests cover now functions with multiple SUT arguments + [ocaml#253](ocaml-gospel/ortac#253): Generated tests cover now functions returning SUT values + [ocaml#259](ocaml-gospel/ortac#259): Generated tests can be run in a separated process with a timeout - Improvements: + [ocaml#245](ocaml-gospel/ortac#245): Fix the analysis of function signature to explicitly not support SUTs inside another type + [ocaml#251](ocaml-gospel/ortac#251): Fix the display of the runnable scenario for value returned by a function that could have raised an exception
n-osborne
added a commit
to n-osborne/opam-repository
that referenced
this pull request
Oct 8, 2024
This release brings a number of new features and improvements: - New features: + [ocaml#247](ocaml-gospel/ortac#247): Generated tests cover now functions with multiple SUT arguments + [ocaml#253](ocaml-gospel/ortac#253): Generated tests cover now functions returning SUT values + [ocaml#259](ocaml-gospel/ortac#259): Generated tests can be run in a separated process with a timeout - Improvements: + [ocaml#245](ocaml-gospel/ortac#245): Fix the analysis of function signature to explicitly not support SUTs inside another type + [ocaml#251](ocaml-gospel/ortac#251): Fix the display of the runnable scenario for value returned by a function that could have raised an exception
n-osborne
added a commit
to n-osborne/opam-repository
that referenced
this pull request
Oct 10, 2024
This release brings a number of new features and improvements: - New features: + [ocaml#247](ocaml-gospel/ortac#247): Generated tests cover now functions with multiple SUT arguments + [ocaml#253](ocaml-gospel/ortac#253): Generated tests cover now functions returning SUT values + [ocaml#259](ocaml-gospel/ortac#259): Generated tests can be run in a separated process with a timeout - Improvements: + [ocaml#245](ocaml-gospel/ortac#245): Fix the analysis of function signature to explicitly not support SUTs inside another type + [ocaml#251](ocaml-gospel/ortac#251): Fix the display of the runnable scenario for value returned by a function that could have raised an exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #248
As suggested in the issue, the PR add a variant with three constructors to
Ortac_runtime_qcheck_stmmaking it possible to pass the information whether the result is a value, a protected value or an exception from the generated tests to the runtime.We don't really have tests for failing tests, which explains why we didn't spot the bug earlier. I'll open an issue for that, to keep this PR small and focused on the fix.