Improve readme clarity and troubleshooting for install script#2125
Merged
Conversation
Clean up readme structure a bit to help with readability. fix instructions which could lead to a sourcing loop if misinterpreted. guidance should direct macos users to simply copy the source snippet manually into their desired profile file. Resolve nvm-sh#2123
nebbles
added a commit
to nebbles/nvm
that referenced
this pull request
Dec 28, 2019
Headings now conform to title case for the first three levels. Level 4 does not conform to title case. Made some corrections as suggested. Included changes recommended in nvm-sh#2125
Contributor
Author
|
I have also noticed that this PR resolves #2130 (it is redundant) |
Contributor
Author
|
I have just fixed issue with tests failing. Was due to some trailing whitespace. Might be worth taking a look at https://pre-commit.com if you're interested. |
ljharb
force-pushed
the
master
branch
2 times, most recently
from
6392ab4 to
d8785da
Compare
ljharb
approved these changes
Jan 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #2123