MTP V2, upgrade to net 8#1329
Merged
Merged
Conversation
* Update to MTP v2 stable * Update NUnit3TestAdapter.nuspec
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the NUnit Test Adapter to version 2 by transitioning from .NET Core 3.1 to .NET 8.0, updating the NUnit Engine to version 3.20.1, and upgrading the Microsoft Testing Platform dependencies to version 2.0.1.
- Updated all target frameworks from
netcoreapp3.1tonet8.0across project files - Upgraded NUnit Engine from 3.18.1 to 3.20.1 and Microsoft Testing Platform packages from 1.9.0 to 2.0.1
- Modernized code syntax and conditional compilation directives for the new framework version
Reviewed Changes
Copilot reviewed 29 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/mock-assembly/mock-assembly.csproj | Updated target framework and removed conditional NUnit package references |
| src/empty-assembly/empty-assembly.csproj | Updated target framework and removed conditional NUnit package references |
| src/NUnitTestAdapterTests/TestDiscoveryTests.cs | Added test ignore attribute and modernized syntax (collection expression, Assert scope) |
| src/NUnitTestAdapterTests/NUnit.TestAdapter.Tests.csproj | Updated target framework and removed conditional package references and custom build target |
| src/NUnitTestAdapterTests/Filtering/VSTestFilterStringTestsLegacy.cs | Refactored LINQ query into separate variable |
| src/NUnitTestAdapterTests/Filtering/FilteringTestUtils.cs | Updated reflection type names to use new Microsoft Testing Platform internal types |
| src/NUnitTestAdapter/TestingPlatformAdapter/NUnitBridgedTestFramework.cs | Converted constructor to primary constructor syntax |
| src/NUnitTestAdapter/TestFilterConverter/TestFilterParserException.cs | Changed conditional compilation from !NETSTANDARD1_6 to NETFRAMEWORK |
| src/NUnitTestAdapter/NUnitEngine/NUnitTestEvent.cs | Added conditional compilation for Serializable attribute and serialization constructor |
| src/NUnitTestAdapter/NUnitEngine/DiscoveryException.cs | Added conditional compilation for Serializable attribute and serialization constructor |
| src/NUnitTestAdapter/NUnit3TestExecutor.cs | Added pragma directives to suppress obsolete API warnings and added null-forgiving operator |
| src/NUnitTestAdapter/NUnit.TestAdapter.csproj | Updated target framework, version numbers, and package references |
| src/NUnitTestAdapter/ExecutionProcesses/IdeExecution.cs | Simplified conditional logic using combined OR expression |
| src/NUnit3AdapterExternalTests/NUnit3AdapterExternalTests.csproj | Updated target framework and removed conditional package references |
| src/NUnit.TestAdapter.Tests.Acceptance/README.md | Changed formatting of note from plain text to bold |
| src/NUnit.TestAdapter.Tests.Acceptance/PropertyTests.cs | Updated framework constant from NetCoreApp31 to Net80 |
| src/NUnit.TestAdapter.Tests.Acceptance/ParanthesisTests.cs | Updated framework constant from NetCoreApp31 to Net80 |
| src/NUnit.TestAdapter.Tests.Acceptance/FixtureTests.cs | Updated framework constant from NetCoreApp31 to Net80 |
| src/NUnit.TestAdapter.Tests.Acceptance/FilterTests.cs | Updated framework constant from NetCoreApp31 to Net80 |
| src/NUnit.TestAdapter.Tests.Acceptance/ExplicitModeNoneTests.cs | Added documentation comment and NonParallelizable attribute, updated framework constant |
| src/NUnit.TestAdapter.Tests.Acceptance/ConsoleOutTests.cs | Updated framework constant from NetCoreApp31 to Net80 |
| src/NUnit.TestAdapter.Tests.Acceptance/AcceptanceTests.cs | Removed legacy framework constants, updated test data sources, and changed Microsoft Test SDK version |
| nuget/NUnit3TestAdapter.nuspec | Updated version numbers, descriptions, dependencies, and file paths from netcoreapp3.1 to net8.0 |
| build.cake | Updated version, renamed constants, and updated file paths from netcoreapp3.1 to net8.0 |
| NUnit3TestAdapter.sln | Updated solution folder name from netcoreapp3.1 to net8.0 |
| LICENSE | Updated copyright year to 2026 |
| Directory.Packages.props | Updated package versions for NUnit Engine and Microsoft Testing Platform packages |
| .github/workflows/NUnit3TestAdapter.Myget.Publish.yml | Removed .NET 3.1 and 6.0 from setup, keeping only 8.0 |
| .github/workflows/NUnit3TestAdapter.CI.yml | Removed .NET 3.1, 5.0, 6.0, and 7.0 from setup, keeping only 8.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1328 Fixes #1335
This PR upgrades MTP to version 2, skips netcore3.1, adds .net 8, and update the NUnit.Engine to version 3.20.1