Skip to content

feat: refactor octokit usage and remove proxy handling logic#181

Merged
meeroslav merged 1 commit into
nrwl:mainfrom
joh-klein:main
Mar 6, 2025
Merged

feat: refactor octokit usage and remove proxy handling logic#181
meeroslav merged 1 commit into
nrwl:mainfrom
joh-klein:main

Conversation

@joh-klein

Copy link
Copy Markdown
Contributor

Replaced custom ProxifiedClient with getOctokit from GitHub Actions SDK for simplicity. Removed proxy-related code, including unnecessary imports and the proxy plugin function. Streamlined the codebase while maintaining required functionality.

closes #180

Replaced custom ProxifiedClient with `getOctokit` from GitHub Actions SDK for simplicity. Removed proxy-related code, including unnecessary imports and the proxy plugin function. Streamlined the codebase while maintaining required functionality.
@joh-klein

joh-klein commented Mar 5, 2025

Copy link
Copy Markdown
Contributor Author

Please update the package.json version to whatever version you see fit.
I have NOT checked if this works in a proxy environment – but the @actions/github package has a test for proxied environments.

@meeroslav meeroslav changed the title refactor: octokit usage and remove proxy handling logic feat: refactor octokit usage and remove proxy handling logic Mar 6, 2025
@meeroslav meeroslav merged commit b691dd2 into nrwl:main Mar 6, 2025
@meeroslav

Copy link
Copy Markdown
Contributor

Potentially fixes #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why use @octokit/action? Maybe @actions/github is enough

2 participants