rays reshape fix#958
Open
AlisherBlack wants to merge 2 commits into
Open
Conversation
AlisherBlack
force-pushed
the
fix-reshape-rays
branch
from
0f951af to
b5c8aee
Compare
AlisherBlack
force-pushed
the
fix-reshape-rays
branch
from
b5c8aee to
9196497
Compare
AlisherBlack
changed the title
AlisherBlack
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eval3d pixel rasterizer (rasterize_to_pixels_eval3d_extra) expects per-ray input flattened as (..., C, H*W, 6): it derives P = rays.shape[-2] and its assert_shape wants rank (num_batch_dims + 3). The public API above takes (and asserts) the image-shaped (..., C, H, W, 6), so flatten the H, W dims here. Row-major flattening matches the kernel's pixel index (row * W + col) and the image-shaped output, so no reshape is needed on the returned colors/alphas.
#967