Skip to content

Replace an NBSP (ASCII 160) with a space (ASCII 32) in sections.yml#195

Merged
jgonggrijp merged 2 commits into
mustache:masterfrom
alterationx10:patch-1
Jan 18, 2025
Merged

Replace an NBSP (ASCII 160) with a space (ASCII 32) in sections.yml#195
jgonggrijp merged 2 commits into
mustache:masterfrom
alterationx10:patch-1

Conversation

@alterationx10

Copy link
Copy Markdown
Contributor

I ran into an issue parsing the json version of this file on a linux/amd64 test runner (but not my local arm64 Mac). Took me a while to find it, but I believe it's because of this NBSP (ASCII 160) character.

Most parsers would probably handle this better than the one I made 😁 , but I also thought there wouldn't be any harm in swapping it out for an SPACE (ASCII 32)

Replace a NBSP (ASCII 160) with a space (ASCII 32)

@jgonggrijp jgonggrijp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bringing this to our attention and for contributing a fix.

I reviewed the change with two other programs to triple-check that this is only replacing one NBSP with a regular space. I see no reason why that particular space would need to be a NBSP, so I agree this change is for the better.

If you don't mind, please update the JSON as well. Otherwise, just let me know and I will do it.

@alterationx10

Copy link
Copy Markdown
Contributor Author

I ran rake build, but on my machine it updates the NBSP, but it also modifies every json file (by re-formatting empty objects/arrays to be on one line stead of two), so I opted to remove the NBSP in the json manually, if that's ok.

@jgonggrijp jgonggrijp merged commit 9cb20c3 into mustache:master Jan 18, 2025
@mustache mustache deleted a comment Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants