Make code more idiomatic

[mre]

No description provided.

[omarandlorraine]

The commit mostly removes unnecessary casts. What does clippy say about these?

[omarandlorraine]

Also regarding impl Default for Status that is better. But I'm wondering about the TODO which reads "Revisit these defaults.".

On the 6502, the status flags are undefined on power-on. Of course, after a RESET, the disable_interrupts gets set because RESET is an interrupt. So I guess it depends on the semantics of instantiating the CPU object.

[mre]

The commit mostly removes unnecessary casts. What does clippy say about these?

Yeah, that's what clippy suggested, so we should be good. 😉
Maybe should have mentioned that.

On the 6502, the status flags are undefined on power-on. Of course, after a RESET, the disable_interrupts gets set because RESET is an interrupt. So I guess it depends on the semantics of instantiating the CPU object.

True. The change shouldn't change the behavior, so I think we can merge that in for now. From my perspective the current defaults could be seen as random state as well, haha. If there are any fields we should change we can do that of course.

[omarandlorraine]

Yep alright, then I think we're ready to merge the PR 👍

[mre]

Thanks for the review. 👍