Fixed a problem with dependency management filtering in the logged results#1298
Merged
andrzejj0 merged 1 commit intoOct 27, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in dependency management filtering where null values in managed dependencies should act as wildcards when matching against actual dependencies, but were incorrectly being matched using .equals() which caused NullPointerExceptions.
Key Changes:
- Fixed the
dependenciesMatchmethod to treat null values in managed dependencies as wildcards rather than attempting to match them - Changed visibility from
protectedto package-private (static) for better encapsulation - Added comprehensive test coverage for the wildcard matching behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| DisplayDependencyUpdatesMojo.java | Fixed null handling in dependenciesMatch to treat null managed dependency fields as wildcards and inverted the logic for scope/classifier matching |
| DisplayDependencyUpdatesMojoTest.java | Added test coverage for wildcard matching behavior with null values in managed dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
slachiewicz
approved these changes
Oct 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DisplayDependencyManagement should only show updates for dependency management entries, if these are not present in dependencies: it uses
dependenciesMatchto filter those. However, the function was not correct: it should treat no values in dependency management as "wildcards" and not try matching nulls against dependency values.Fixed that. A minor issue.
Edit: Copilot review is not entirely correct. There were no problems with NPE with this bug, it's rather that the matching was incorrect. It should treat not defined fields in dependency management as wildcards rather than match nulls with dependencies.