Remove to_openai and from_openai from InstructRequest#251
Merged
Conversation
joa-stdn
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InstructRequestis an internal class used by tokenizers; the OpenAI conversion helpers belong on the publicChatCompletionRequest. This removes the redundantto_openai/from_openaifromInstructRequestand documents that the class is internal.Changes
InstructRequest.to_openaiandInstructRequest.from_openai(ChatCompletionRequestversions are untouched).InstructRequestdocstring: it is for internal use only; external users should useChatCompletionRequestto build requests and convert to/from the OpenAI format.tests/test_converters.pyto drop theInstructRequestOpenAI-conversion cases.Verification
tests/test_converters.py: 99 passedrequest.py: 5 passed