fix: set the teams-channel-picker dropdown to overlay all other elements#2337
Conversation
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
|
Thank you for creating a Pull Request @musale. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
|
The updated storybook is available here |
1 similar comment
|
The updated storybook is available here |
|
The dark mode doesn't have a dark token for the input
|
sebastienlevert
left a comment
sebastienlevert
left a comment
There was a problem hiding this comment.
The hover now works, but we can see the content underneath.
ghost
added
the
|
The updated storybook is available here |
|
The updated storybook is available here |
|
The updated storybook is available here |
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
Fixing the dark theme has fixed this issue too. It is overlaying correctly. |
|
The updated storybook is available here |
|
Something weird happened... Now we can't close the expanded teams. Is it related to this change? @musale
|
Let me check this out. updateI'm not sure why the caret opens but doesn't close the tree items. Taking a deep dive to figure it out. |
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
|
The updated storybook is available here |
|
Seems a lot better now! |
|
Clicking on the chevron when the tree node is expanded does nothing in my testing, however clicking to the left or right of the chevron does cause the expanded tree node to collapse |
|
I retested and I have the same. I need to go left / right and even sometimes clicking doesn't change a thing... It's a bit random right now. |
|
It's worth noting that this chevron expand/collapse issue is one that is present in the next/fluentui branch and not a regression introduced by this change. |
|
We can create a new issue then! |
|
The updated storybook is available here |
|
New issue: #2373 |
3 participants
Closes #2288
PR Type
Description of the changes
Make the fluentcard that is in the dropdown to appear on top of all elements below the teams channel picker.
PR checklist
yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense)Other information