Move pre-check errors to post-check#6236
Merged
Merged
Conversation
florelis
approved these changes
May 20, 2026
| // There was a bug in InstallService where admin users were incorrectly identified as non-admin, | ||
| // causing false access denied errors; fixed in 10.0.26100.0. On older OS versions, convert any | ||
| // failure under these conditions to the error that was previously always returned. | ||
| if (FAILED(hr) && |
Member
There was a problem hiding this comment.
Should we check for the specific HR?
Member
Author
There was a problem hiding this comment.
I don't know that we know it nor do we know that it is specific to the failure. That could be a future improvement but I don't see it causing any impact with this change.
yao-msft
reviewed
May 20, 2026
| !Runtime::IsCurrentOSVersionGreaterThanOrEqual(Utility::Version{ "10.0.26100.0" })) | ||
| { | ||
| AICLI_LOG(Core, Error, << "Device wide install for msstore type is not supported under admin context on this OS version. Error: " << hr); | ||
| return APPINSTALLER_CLI_ERROR_INSTALL_SYSTEM_NOT_SUPPORTED; |
Contributor
There was a problem hiding this comment.
I know it's a copy paste but nit: RETURN_HR()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
We had some pre-check errors for various issues in the OS. Move those to attempt the operation and convert any failures in the scenario on the older OS to the well-known HRESULT.
🔍 Validation
Existing regression tests.
Microsoft Reviewers: Open in CodeFlow