This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Refactor AdoTemplate rendering#3370
Merged
Merged
Conversation
tevoinea
commented
Aug 1, 2023
tevoinea
commented
Aug 1, 2023
Codecov Report
@@ Coverage Diff @@
## main #3370 +/- ##
==========================================
+ Coverage 31.69% 31.86% +0.17%
==========================================
Files 308 308
Lines 37615 37659 +44
==========================================
+ Hits 11921 12000 +79
+ Misses 25694 25659 -35
|
nharper285
approved these changes
Aug 1, 2023
AdamL-Microsoft
pushed a commit
that referenced
this pull request
Aug 1, 2023
* . * Add tests and complete refactor * Remove done todo * Log the query we created
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
Closes #3369
Closes #1692
Info on Pull Request
What does this include?
RenderedAdoTemplateAdoTemplateinto aRenderedAdoTemplate. During that process, we can enforce limitations imposed by ADO such as a max title lengthAdoConnectorto only work with aRenderedAdoTemplateto enforce the behavior from the previous 2 bullet pointsAdoConnectorno longer has the ability to render fields in a configExistingWorkItemsinto 2 parts: - Allowing us to test the query we generateAdoTemplatetoRenderedAdoTemplateValidation Steps Performed
How does someone test & validate?
Validated in test instance: