fix: preserve chronological message order in MessageFilterAgent._apply_filter - #7981
Open
Varshith-Kali wants to merge 1 commit into
Open
fix: preserve chronological message order in MessageFilterAgent._apply_filter#7981Varshith-Kali wants to merge 1 commit into
Varshith-Kali wants to merge 1 commit into
Conversation
…y_filter _apply_filter iterated per_source in config order and appended each source's matches, emitting messages in config order rather than their original chronological order. This broke the class's own documented example (A->B->A->B->C graph where B sees A's newer message before its own prior reply). Fixed by sorting the result list by each message's original position in the input sequence before returning it. Fixes microsoft#7971
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7971
MessageFilterAgent._apply_filter iterates per_source in config order and
appends each source's matches, emitting messages in config order rather
than their original chronological order. This breaks the class's own
documented example (A->B->A->B->C graph where B sees A's newer message
before its own prior reply).
What changed
Added a sort by original input position after building the result list.
The fix is a one-liner: result.sort(key=lambda m: messages.index(m))
preceded by an explanatory comment referencing the issue.
Test
Added 5 tests covering:
Files