Add VSSDK003 Support async tool windows#25
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=========================================
Coverage ? 91.54%
=========================================
Files ? 6
Lines ? 213
Branches ? 0
=========================================
Hits ? 195
Misses ? 18
Partials ? 0
Continue to review full report at Codecov.
|
jdrobison
approved these changes
Feb 16, 2018
| } | ||
|
|
||
| /// <summary> | ||
| /// Called to test a C# DiagnosticAnalyzer when applied on multiple inputted string as a source |
Contributor
There was a problem hiding this comment.
Typo: "...multiple inputted strings..."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VSSDK003 Support async tool windows
Offer an async tool window factory for your tool windows so Visual Studio startup
is fast if the tool window is initially visible, and remains responsive when your
tool window is activated later in the session.
This analyzer only flags synchronous tool windows when proffered from an
AsyncPackage-derivedVS package and when targeting Visual Studio 2017 Update 6 or later.
Examples of patterns that are flagged by this analyzer
Solution
Override the async tool window factory methods on your
AsyncPackage-derived classand offer a constructor overload in your
ToolWindowPane-derived class that accepts one parameter.Closes #21