Update llvm-project#6265
Conversation
There was a problem hiding this comment.
Pull request overview
Updates this repo’s libc++ test expectation baselines to match upstream llvm-project test renames and newly observed range.stride.view outcomes.
Changes:
- Update
numeric.ops.satexpected failures to the newsaturating_*test names. - Update the
alg.foldexpected skip to the renamedranges.fold_left.pass.cpp. - Add/categorize new
range.stride.viewexpected failures (iterator/base.pass.cpp,end.pass.cpp) with rationale comments.
Show a summary per file
| File | Description |
|---|---|
| tests/libcxx/expected_results.txt | Refreshes expected result entries to align with upstream test renames and newly categorized range.stride.view failures. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
| # Not analyzed. | ||
| # MSVC error C2036: '_Sent': unknown size | ||
| # Clang error: arithmetic on a pointer to void | ||
| std/ranges/range.adaptors/range.stride.view/end.pass.cpp FAIL |
There was a problem hiding this comment.
This is probably a bug in MSVC STL.
Lines 2913 to 2914 in fe3b0ac
That test case uses void* as the sentinel type, so we can't perform _Se + 0 for decay. IIUC +_Se works. Perhaps we can fix this in a later PR.
There was a problem hiding this comment.
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
pyjwt[crypto]==2.12.1,cryptography==47.0.0, andurllib3==2.6.3llvm/llvm-project#194707left_folds.pass.cppwas renamed toranges.fold_left.pass.cpp.ranges::fold_left_firstandranges::fold_left_first_with_iterllvm/llvm-project#180214numeric.ops.sattests were renamed.range.stride.viewfailures.