Skip to content

Update llvm-project#6265

Merged
StephanTLavavej merged 6 commits into
microsoft:mainfrom
StephanTLavavej:update-llvm
Apr 29, 2026
Merged

Update llvm-project#6265
StephanTLavavej merged 6 commits into
microsoft:mainfrom
StephanTLavavej:update-llvm

Conversation

@StephanTLavavej

@StephanTLavavej StephanTLavavej commented Apr 28, 2026

Copy link
Copy Markdown
Member

@StephanTLavavej StephanTLavavej requested a review from a team as a code owner April 28, 2026 16:51
Copilot AI review requested due to automatic review settings April 28, 2026 16:51
@StephanTLavavej StephanTLavavej added the test Related to test code label Apr 28, 2026
@github-project-automation github-project-automation Bot moved this to Initial Review in STL Code Reviews Apr 28, 2026
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in STL Code Reviews Apr 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this repo’s libc++ test expectation baselines to match upstream llvm-project test renames and newly observed range.stride.view outcomes.

Changes:

  • Update numeric.ops.sat expected failures to the new saturating_* test names.
  • Update the alg.fold expected skip to the renamed ranges.fold_left.pass.cpp.
  • Add/categorize new range.stride.view expected failures (iterator/base.pass.cpp, end.pass.cpp) with rationale comments.
Show a summary per file
File Description
tests/libcxx/expected_results.txt Refreshes expected result entries to align with upstream test renames and newly categorized range.stride.view failures.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in STL Code Reviews Apr 28, 2026
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Apr 28, 2026
@StephanTLavavej

Copy link
Copy Markdown
Member Author

I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required.

Comment on lines +1158 to +1161
# Not analyzed.
# MSVC error C2036: '_Sent': unknown size
# Clang error: arithmetic on a pointer to void
std/ranges/range.adaptors/range.stride.view/end.pass.cpp FAIL

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a bug in MSVC STL.

STL/stl/inc/xutility

Lines 2913 to 2914 in fe3b0ac

if constexpr (is_pointer_v<remove_cvref_t<_Sent>>) {
return _Se + 0;

That test case uses void* as the sentinel type, so we can't perform _Se + 0 for decay. IIUC +_Se works. Perhaps we can fix this in a later PR.

Copilot AI review requested due to automatic review settings April 29, 2026 06:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new

@StephanTLavavej StephanTLavavej merged commit 54063ed into microsoft:main Apr 29, 2026
53 checks passed
@StephanTLavavej StephanTLavavej deleted the update-llvm branch April 29, 2026 19:27
@github-project-automation github-project-automation Bot moved this from Merging to Done in STL Code Reviews Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Related to test code

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants