fix some warnings (and maybe a bug?)#301
Closed
MLXProjects wants to merge 5 commits into
Closed
Conversation
size_t is unsigned, so the compiler throws different signedness comparison warnings.
pathsep and path have different signedness than size_t (which is unsigned)
break was inside of the if brackets, so if the condition wasn't met it would jump to the default: label
Pull request michaelrsweet#288 implemented long long int detection, but seems it was incomplete. If long long int is not available, compiler would throw a "variable set but not used" warning. Seems that the "size" variable is only used in cases where long long int is supported. This commit fixes the warning via defining and using that variable only if long long int is supported.
forgot to fix this one too in the second previous commit
michaelrsweet
added a commit
that referenced
this pull request
Mar 6, 2024
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
casted some sizeof() to prevent signed/unsigned comparison
moved break; outside the if they were at two switch/case statements, not sure if those fallthroughs were intended tho.
at _mxml_vsnprintf, put the char *size variable inside an #ifdef because it's only used if that condition is met