Add zstd decompression support for NSIS archives#475
Merged
Conversation
Add zstd magic detection to both solid and non-solid NSIS code paths in NsisIn.cpp. Add kZstd method type and wire up the existing ZstdDecoder for NSIS streaming decompression. Extend ZstdDecoder with ISequentialInStream, ICompressSetInStream, and ICompressSetOutStreamSize interfaces plus a Read() method, which the NSIS handler requires for incremental decompression. Tested with NSIS installers built using the zstd compression option (both solid and non-solid modes).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add zstd magic detection to both solid and non-solid NSIS code paths in NsisIn.cpp. Add kZstd method type and wire up the existing ZstdDecoder for NSIS streaming decompression. Extend ZstdDecoder with ISequentialInStream, ICompressSetInStream, and ICompressSetOutStreamSize interfaces plus a Read() method, which the NSIS handler requires for incremental decompression.
Tested with NSIS installers built using the zstd compression option (both solid and non-solid modes).