Skip to content

docs: update load-test controller guidance#808

Draft
cursor[bot] wants to merge 1 commit into
masterfrom
cursor/documentation-agent-updates-5460
Draft

docs: update load-test controller guidance#808
cursor[bot] wants to merge 1 commit into
masterfrom
cursor/documentation-agent-updates-5460

Conversation

@cursor
Copy link
Copy Markdown
Contributor

@cursor cursor Bot commented Jun 5, 2026

Summary

Updated the load-testing guide after the master push that added the standalone Agents load-test-ng simulator controller in PR #726 and the initial load-testing documentation in PR #727.

Documentation files changed:

  • docs/load-testing.md: Added controller wiring details for the nested module blank import, minimum server version, config error behavior, trigger mode/frequency behavior, prompt profiles, agent identity validation, and skip conditions for channel mentions/DMs.

PR context used:

Screenshots:

  • Not applicable. The documented changes are load-test controller configuration and module wiring, not UI behavior.

Borderline items:

  • No additional documentation pages were created. The existing docs/load-testing.md guide is the canonical location for these load-test-only details.

Validation:

  • GOTOOLCHAIN=go1.26.3 make check-style

Ticket Link

N/A

Screenshots

N/A

Release Note

NONE
Open in Web View Automation 

Summary by CodeRabbit

  • Documentation
    • Enhanced load testing documentation with expanded setup instructions, clarified configuration requirements for the Agents load testing framework, and improved troubleshooting guidance covering common issues and skip conditions.

Co-authored-by: Nick Misasi <nick13misasi@gmail.com>
@cursor cursor Bot requested a review from nickmisasi June 5, 2026 14:22
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

🤖 LLM Evaluation Results

OpenAI

⚠️Overall: 21/28 tests passed (75.0%)

Provider Total Passed Failed Pass Rate
⚠️ OPENAI 28 21 7 75.0%

❌ Failed Evaluations

Show 7 failures

OPENAI

1. TestReactEval/[openai]_react_cat_message

  • Score: 0.00
  • Rubric: The word/emoji is a cat emoji or a heart/love emoji
  • Reason: The output is the text string "heart_eyes_cat", not an actual cat emoji (e.g., 😺) or a heart/love emoji (e.g., ❤️).

2. TestConversationMentionHandling/[openai]_conversation_from_attribution_long_thread.json

  • Score: 0.00
  • Rubric: is a list of bugs
  • Reason: The output does not provide any actual bug entries; it states it cannot access the bug tracker and only offers a template and instructions for providing bugs.

3. TestConversationMentionHandling/[openai]_conversation_from_attribution_long_thread.json

  • Score: 0.00
  • Rubric: includes a description of each bug
  • Reason: The output does not include descriptions of any actual bugs; it only states inability to access the tracker and provides a template/request for bug details. Therefore it does not include a description of each bug.

4. TestConversationMentionHandling/[openai]_conversation_from_attribution_long_thread.json

  • Score: 0.00
  • Rubric: attributes each bug to a user
  • Reason: The output does not list any bugs or attribute any bug to a specific user; it only asks the user to provide bug details and offers a template with an empty 'Reported by' column.

5. TestConversationMentionHandling/[openai]_conversation_from_attribution_long_thread.json

  • Score: 0.00
  • Rubric: attributes the bug about trying to save without a color and the save button not doing anything to @maria.nunez
  • Reason: The output does not mention the specific bug about trying to save without a color or that the save button does nothing, and it does not attribute any bug to @maria.nunez. It only provides a generic template and request for more information.

6. TestConversationMentionHandling/[openai]_conversation_from_attribution_long_thread.json

  • Score: 0.00
  • Rubric: the bug about the end user being able to change channel banner is attributed to @maria.nunez
  • Reason: The output does not list or attribute any specific bug, and it does not mention the bug about an end user being able to change the channel banner or attribute it to @maria.nunez.

7. TestDirectMessageConversations/[openai]_bot_dm_tool_introspection

  • Score: 0.00
  • Rubric: mentions Github and refers to the documentation
  • Reason: The output refers to documentation (Mattermost docs link) but does not mention GitHub anywhere. Since the rubric requires both mentioning Github and referring to the documentation, it fails.

Anthropic

⚠️Overall: 21/28 tests passed (75.0%)

Provider Total Passed Failed Pass Rate
⚠️ ANTHROPIC 28 21 7 75.0%

❌ Failed Evaluations

Show 7 failures

ANTHROPIC

1. TestReactEval/[anthropic]_react_cat_message

  • Score: 0.00
  • Rubric: The word/emoji is a cat emoji or a heart/love emoji
  • Reason: The output is the text "heart_eyes_cat" rather than an actual cat emoji (e.g., 😺/🐱) or a heart/love emoji (e.g., ❤️/😍).

2. TestConversationMentionHandling/[anthropic]_conversation_from_attribution_long_thread.json

  • Score: 0.00
  • Rubric: is a list of bugs
  • Reason: The output explains it cannot access bug reports and suggests ways to find them, but it does not provide any actual list of bugs.

3. TestConversationMentionHandling/[anthropic]_conversation_from_attribution_long_thread.json

  • Score: 0.00
  • Rubric: includes a description of each bug
  • Reason: The output explicitly says it cannot access bug reports or summarize them and provides only suggestions on how to compile a list. It does not include any bug descriptions at all, let alone a description of each bug.

4. TestConversationMentionHandling/[anthropic]_conversation_from_attribution_long_thread.json

  • Score: 0.00
  • Rubric: attributes each bug to a user
  • Reason: The output does not attribute any bugs to any users; it only states inability to access bug reports and suggests ways to compile a list.

5. TestConversationMentionHandling/[anthropic]_conversation_from_attribution_long_thread.json

  • Score: 0.00
  • Rubric: attributes the bug about trying to save without a color and the save button not doing anything to @maria.nunez
  • Reason: The output states it cannot access bug reports and provides general guidance, but it does not mention the specific bug (saving without a color / save button not doing anything) nor attribute it to @maria.nunez.

6. TestConversationMentionHandling/[anthropic]_conversation_from_attribution_long_thread.json

  • Score: 0.00
  • Rubric: the bug about the end user being able to change channel banner is attributed to @maria.nunez
  • Reason: The output does not mention the bug about an end user being able to change the channel banner, nor does it attribute that bug to @maria.nunez. It only states a lack of access to bug reports and suggests ways to compile a list.

7. TestDirectMessageConversations/[anthropic]_bot_dm_tool_introspection

  • Score: 0.50
  • Rubric: mentions Github and refers to the documentation
  • Reason: The output refers to documentation (docs.mattermost.com) but does not mention GitHub anywhere, so it does not satisfy the requirement to mention GitHub and refer to the documentation.

This comment was automatically generated by the eval CI pipeline.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 5, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 0b72abca-4510-426d-a585-de3a5e914bb5

📥 Commits

Reviewing files that changed from the base of the PR and between 00ae379 and 468bdfd.

📒 Files selected for processing (1)
  • docs/load-testing.md

📝 Walkthrough

Walkthrough

Updated docs/load-testing.md with expanded setup and configuration guidance for Agents load testing via mattermost-load-test-ng. Clarified cross-repository wiring, controller activation, required plugin registration, trigger frequency semantics, simulator configuration values, agent identity requirements, and enhanced troubleshooting procedures.

Changes

Load Testing Documentation Expansion

Layer / File(s) Summary
Setup and Agents enablement guidance
docs/load-testing.md
Expanded setup instructions with explicit cross-repository blank-import wiring, controller activation scope, required mattermost-ai plugin registration in EnabledPlugins, and minimum server version requirement.
Controller configuration and trigger semantics
docs/load-testing.md
Clarified that controller configuration read errors are returned through action responses rather than panics, and documented trigger frequency interpretation as relative weights with actions omitted when frequency is zero.
Simulator configuration and agent identity requirements
docs/load-testing.md
Documented valid triggerMode and promptProfile configuration values, requirements to configure agentUsername or agentUserID when enabled actions have non-zero frequency, and the specific skip behaviour for channel mentions and DM actions.
Troubleshooting enhancements
docs/load-testing.md
Added troubleshooting checks for missing simulated agent traffic, agent-user targeting mismatches, and conditions under which channel mentions or DMs skip without error.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

Setup Cloud Test Server

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating load-testing documentation to provide controller guidance for the load-test-ng simulator.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/documentation-agent-updates-5460

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant