Skip to content

feat: Add load cell gram scales in misc panel#2173

Merged
meteyou merged 2 commits into
mainsail-crew:developfrom
rcloran:gram-scale
Apr 21, 2025
Merged

feat: Add load cell gram scales in misc panel#2173
meteyou merged 2 commits into
mainsail-crew:developfrom
rcloran:gram-scale

Conversation

@rcloran

@rcloran rcloran commented Mar 22, 2025

Copy link
Copy Markdown
Contributor

Description

This adds a new general purpose MiscellaneousSensor, with support for only load_cell gram scales. This is just a simple single line entry in the MiscellaneousPanel, with a getter to extract the value from the printer state.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

With an uncalibrated load cell:

image

After calibration:

image

[optional] Are there any post-deployment tasks we need to perform?

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 22, 2025
This adds a new general purpose `MiscellaneousSensor`, with support for
only load_cell gram scales. This is just a simple single line entry in
the MiscellaneousPanel, with a getter to extract the value from the
printer state.

Signed-off-by: Russell Cloran <rcloran@gmail.com>
@rcloran

rcloran commented Mar 22, 2025

Copy link
Copy Markdown
Contributor Author

The gram scale support was added to Klipper recently, in Klipper3d/klipper@06d65ef

@garethky , not sure if you have anything to add here, but mentioning you in case you do

Signed-off-by: Stefan Dej <meteyou@gmail.com>
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 21, 2025
@meteyou meteyou merged commit 4ff0625 into mainsail-crew:develop Apr 21, 2025
@meteyou

meteyou commented Apr 21, 2025

Copy link
Copy Markdown
Member

@rcloran sry for the delay and thx for your PR! i just changed the empty value from '---' to '--' because we always use 2 dash in the rest of the gui.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants