Skip to content
This repository was archived by the owner on Jan 12, 2026. It is now read-only.

Add files via upload#14

Open
keesma wants to merge 1 commit into
luebbe:masterfrom
keesma:master
Open

Add files via upload#14
keesma wants to merge 1 commit into
luebbe:masterfrom
keesma:master

Conversation

@keesma

@keesma keesma commented Mar 7, 2021

Copy link
Copy Markdown

Added support for BMP280 (based on BME280)

Added support for BMP280 (based on BME280)

@luebbe luebbe left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
One question: Is the BME280 an "extension" of the BMP280? I always thought so, but neve checked, because I don't have a BMP280.
In this case we could inherit the BME280 from the BMP280 (or create a common BMx280 base class) and save a lot of duplicate code.
Do the BME and BMP even share the same I2C addresses?

@keesma

keesma commented Mar 9, 2021 via email

Copy link
Copy Markdown
Author

@luebbe

luebbe commented Mar 9, 2021

Copy link
Copy Markdown
Owner

There is a lot that can go into a common base class when I look at the code. I'll let you finish your PR and afterwards I'll refactor.
I'm also thinking about making the sensor nodes more generic. loop() is basically always the same, only taking the measurement differs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants