This repository was archived by the owner on Jan 12, 2026. It is now read-only.
Add files via upload#14
Open
keesma wants to merge 1 commit into
Open
Conversation
Added support for BMP280 (based on BME280)
luebbe
reviewed
Mar 8, 2021
luebbe
left a comment
Owner
There was a problem hiding this comment.
Thanks for your contribution.
One question: Is the BME280 an "extension" of the BMP280? I always thought so, but neve checked, because I don't have a BMP280.
In this case we could inherit the BME280 from the BMP280 (or create a common BMx280 base class) and save a lot of duplicate code.
Do the BME and BMP even share the same I2C addresses?
Author
|
The BME280 also measures humidity. The other functions are the same. There
is a different underlying library from Adafruit. The I2C addresses are the
same but the device type is different. I am not sure what the best way is
handling duplicate code. I used the BME280 code as a base and made some
adjustments.
While using it I noticed that the BMP280 cannot do forced measurements. I might have to provide updated source code for this.
|
Owner
|
There is a lot that can go into a common base class when I look at the code. I'll let you finish your PR and afterwards I'll refactor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for BMP280 (based on BME280)